d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/mlx4: fix drop queue error handling

Browse Source 
The function mlx4_drop_get() creates pointer to a struct mlx4_drop and
if needed allocates by rte_malloc.

If the allocation is failed the function goes to label “error”, and
there does dereference to a null pointer.

Skip resources cleaning when the memory allocation is failed.

Coverity issue: 146206
Coverity issue: 146146
Fixes: d3a7e09234 ("net/mlx4: allocate drop flow resources on demand")
Cc: stable@dpdk.org

Signed-off-by: Michael Baum <michaelba@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
This commit is contained in:
Michael Baum 2020-05-06 16:27:54 +00:00 committed by Ferruh Yigit
parent c8f0abe7f8
commit 6f155c0b9d
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/net/mlx4/mlx4_flow.c
View File

@ -980,12 +980,13 @@ mlx4_drop_get(struct mlx4_priv *priv)
priv->drop = drop; priv->drop = drop;
return drop; return drop;
error: error:
if (drop->qp) if (drop) {
claim_zero(mlx4_glue->destroy_qp(drop->qp)); if (drop->qp)
if (drop->cq) claim_zero(mlx4_glue->destroy_qp(drop->qp));
claim_zero(mlx4_glue->destroy_cq(drop->cq)); if (drop->cq)
if (drop) claim_zero(mlx4_glue->destroy_cq(drop->cq));
rte_free(drop); rte_free(drop);
}
rte_errno = ENOMEM; rte_errno = ENOMEM;
return NULL; return NULL;
} }