d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/testpmd: fix minor signed overflow in a constant

Browse Source 
The expression (192 << 24) has an undefined behavior since:
- the integer constant 192 has type int, and
- 192 x 2^24 is not representable as an int.

Suffixing 192 with U defines a behavior since:
- the integer constant 192U has type unsigned int, and
- the value of (192U << 24) is defined as
  (192 x 2^24) % (UINT_MAX + 1)

This minor bug was found using TrustInSoft Analyzer.

Signed-off-by: Julien Cretin <julien.cretin@trust-in-soft.com>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
This commit is contained in:
Julien Cretin 2014-05-12 17:35:09 +02:00 committed by Thomas Monjalon
parent 2612a4b935
commit 6f8d4ded4a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/test-pmd/txonly.c
View File

@ -76,8 +76,8 @@
#define UDP_SRC_PORT 1024
#define UDP_DST_PORT 1024
#define IP_SRC_ADDR ((192 << 24) | (168 << 16) | (0 << 8) | 1)
#define IP_DST_ADDR ((192 << 24) | (168 << 16) | (0 << 8) | 2)
#define IP_SRC_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 1)
#define IP_DST_ADDR ((192U << 24) | (168 << 16) | (0 << 8) | 2)
#define IP_DEFTTL 64 /* from RFC 1340. */
#define IP_VERSION 0x40