examples/vhost_scsi: fix null-check for parameter

Coverity points out that there is a check in the main thread loop for the
ctrlr->bdev being NULL, but by that stage the pointer has already been
dereferenced. Therefore, for safety, before we enter the loop do an
initial check on the parameter structure.

Coverity issue: 158657
Fixes: db75c7af19bb ("examples/vhost_scsi: introduce a new sample app")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
This commit is contained in:
Bruce Richardson 2019-04-08 10:46:37 +01:00 committed by Thomas Monjalon
parent f380206979
commit 6fd5b5734f

View File

@ -285,6 +285,12 @@ ctrlr_worker(void *arg)
cpu_set_t cpuset;
pthread_t thread;
if (ctrlr == NULL || ctrlr->bdev == NULL) {
fprintf(stderr, "%s: Error, invalid argument passed to worker thread\n",
__func__);
exit(0);
}
thread = pthread_self();
CPU_ZERO(&cpuset);
CPU_SET(0, &cpuset);