d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/hns3: fix RSS filter restore

Browse Source 
Currently, driver sets RSS function to 'RTE_ETH_HASH_FUNCTION_MAX'
when user flush all rules in order to judge whether driver needs
to restore RSS rules. In fact, all rules are saved in flow RSS list.
So there is no need to modify RSS function to this macro. And this
list can be used to restore. The modification of RSS function may
introduce new problem.

Fixes: eb158fc756a5 ("net/hns3: fix config when creating RSS rule after flush")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
This commit is contained in:
Huisong Li 2022-09-30 15:22:03 +08:00 committed by Andrew Rybchenko
parent 0d81da2559
commit 705a508003
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
drivers/net/hns3/hns3_flow.c
View File

@ -1587,8 +1587,6 @@ hns3_config_rss_filter(struct rte_eth_dev *dev,
rss_info->conf.queue_num = 0;
}
/* set RSS func invalid after flushed */
rss_info->conf.func = RTE_ETH_HASH_FUNCTION_MAX;
return 0;
}
@ -1659,13 +1657,23 @@ int
hns3_restore_rss_filter(struct rte_eth_dev *dev)
{
struct hns3_adapter *hns = dev->data->dev_private;
struct hns3_rss_conf_ele *filter;
struct hns3_hw *hw = &hns->hw;
int ret = 0;
/* When user flush all rules, it doesn't need to restore RSS rule */
if (hw->rss_info.conf.func == RTE_ETH_HASH_FUNCTION_MAX)
return 0;
TAILQ_FOREACH(filter, &hw->flow_rss_list, entries) {
if (!filter->filter_info.valid)
continue;
return hns3_config_rss_filter(dev, &hw->rss_info, true);
ret = hns3_config_rss_filter(dev, &filter->filter_info, true);
if (ret != 0) {
hns3_err(hw, "restore RSS filter failed, ret=%d", ret);
goto out;
}
}
out:
return ret;
}
static int