d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/testpmd: fix SW checksum calculation enabling

Browse Source 
In current design, we can't enable SW checksum calculation
for the devices which don't have checksum offloading abilities
via the command "csum set ip|tcp|udp|sctp|outer-ip sw <port_id>".
But SW checksum calculation shouldn't depend on HW offloading
abilities. This patch is to fix this issue.

Fixes: 3926dd2b6668 ("app/testpmd: enforce offload capabilities check")

Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
Reviewed-by: Shahaf Shuler <shahafs@mellanox.com>
This commit is contained in:
Jiayu Hu 2018-01-25 10:13:44 +08:00 committed by Thomas Monjalon
parent 8b9bd0efe0
commit 7132ca8fa8
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
app/test-pmd/cmdline.c
View File

@ -3706,40 +3706,40 @@ cmd_csum_parsed(void *parsed_result,
hw = 1;
if (!strcmp(res->proto, "ip")) {
if (dev_info.tx_offload_capa &
DEV_TX_OFFLOAD_IPV4_CKSUM) {
if (hw == 0 || (dev_info.tx_offload_capa &
DEV_TX_OFFLOAD_IPV4_CKSUM)) {
csum_offloads |= DEV_TX_OFFLOAD_IPV4_CKSUM;
} else {
printf("IP checksum offload is not supported "
"by port %u\n", res->port_id);
}
} else if (!strcmp(res->proto, "udp")) {
if (dev_info.tx_offload_capa &
DEV_TX_OFFLOAD_UDP_CKSUM) {
if (hw == 0 || (dev_info.tx_offload_capa &
DEV_TX_OFFLOAD_UDP_CKSUM)) {
csum_offloads |= DEV_TX_OFFLOAD_UDP_CKSUM;
} else {
printf("UDP checksum offload is not supported "
"by port %u\n", res->port_id);
}
} else if (!strcmp(res->proto, "tcp")) {
if (dev_info.tx_offload_capa &
DEV_TX_OFFLOAD_TCP_CKSUM) {
if (hw == 0 || (dev_info.tx_offload_capa &
DEV_TX_OFFLOAD_TCP_CKSUM)) {
csum_offloads |= DEV_TX_OFFLOAD_TCP_CKSUM;
} else {
printf("TCP checksum offload is not supported "
"by port %u\n", res->port_id);
}
} else if (!strcmp(res->proto, "sctp")) {
if (dev_info.tx_offload_capa &
DEV_TX_OFFLOAD_SCTP_CKSUM) {
if (hw == 0 || (dev_info.tx_offload_capa &
DEV_TX_OFFLOAD_SCTP_CKSUM)) {
csum_offloads |= DEV_TX_OFFLOAD_SCTP_CKSUM;
} else {
printf("SCTP checksum offload is not supported "
"by port %u\n", res->port_id);
}
} else if (!strcmp(res->proto, "outer-ip")) {
if (dev_info.tx_offload_capa &
DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM) {
if (hw == 0 || (dev_info.tx_offload_capa &
DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM)) {
csum_offloads |=
DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM;
} else {