d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/mlx5/hws: fix disconnecting matcher

Browse Source 
This patch fixes the matcher disconnection handling, by removing the RTC
references from flow table if the currently removed matcher was the last
one for the given table. As a result RTC in this matcher can be
correctly freed, since there are no dangling references to the RTC.

Fixes: c467608215 ("net/mlx5/hws: add matcher object")

Signed-off-by: Erez Shitrit <erezsh@nvidia.com>
Signed-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
Reviewed-by: Alex Vesker <valex@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
This commit is contained in:
Erez Shitrit 2022-11-09 09:54:31 +00:00 committed by Raslan Darawsheh
parent 0189565118
commit 73be9af44e
1 changed files with 35 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
drivers/net/mlx5/hws/mlx5dr_matcher.c
View File

@ -36,6 +36,30 @@ static void mlx5dr_matcher_destroy_end_ft(struct mlx5dr_matcher *matcher)
mlx5dr_table_destroy_default_ft(matcher->tbl, matcher->end_ft);
}
static int mlx5dr_matcher_free_rtc_pointing(uint32_t fw_ft_type,
enum mlx5dr_table_type type,
struct mlx5dr_devx_obj *devx_obj)
{
struct mlx5dr_cmd_ft_modify_attr ft_attr = {0};
int ret;
if (type != MLX5DR_TABLE_TYPE_FDB)
return 0;
ft_attr.modify_fs = MLX5_IFC_MODIFY_FLOW_TABLE_RTC_ID;
ft_attr.type = fw_ft_type;
ft_attr.rtc_id_0 = 0;
ft_attr.rtc_id_1 = 0;
ret = mlx5dr_cmd_flow_table_modify(devx_obj, &ft_attr);
if (ret) {
DR_LOG(ERR, "Failed to disconnect previous RTC");
return ret;
}
return 0;
}
static int mlx5dr_matcher_connect(struct mlx5dr_matcher *matcher)
{
struct mlx5dr_cmd_ft_modify_attr ft_attr = {0};
@ -148,6 +172,17 @@ static int mlx5dr_matcher_disconnect(struct mlx5dr_matcher *matcher)
LIST_REMOVE(matcher, next);
if (!next) {
/* ft no longer points to any RTC, drop refcount */
ret = mlx5dr_matcher_free_rtc_pointing(tbl->fw_ft_type,
tbl->type,
prev_ft);
if (ret) {
DR_LOG(ERR, "Failed to reset last RTC refcount");
return ret;
}
}
return 0;
}