d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/ice/base: refactor to avoid need to retry

Browse Source 
The ice_discover_caps function is used to read the device and function
capabilities, updating the hardware capabilities structures with
relevant data.

The exact number of capabilities returned by the hardware is unknown
ahead of time. The AdminQ command will report the total number of
capabilities in the return buffer.

The current implementation involves requesting capabilities once,
reading this returned size, and then re-requested with that size.

This isn't really necessary. The firmware interface has a maximum size
of ICE_AQ_MAX_BUF_LEN. Firmware can never return more than
ICE_AQ_MAX_BUF_LEN / sizeof(struct ice_aqc_list_caps_elem) capabilities.

Avoid the retry loop by simply allocating a buffer of size
ICE_AQ_MAX_BUF_LEN. This is significantly simpler than retrying. The
extra allocation isn't a big deal, as it will be released after we
finish parsing the capabilities.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
Acked-by: Qiming Yang <qiming.yang@intel.com>
This commit is contained in:
Qi Zhang 2020-06-11 16:43:22 +08:00 committed by Ferruh Yigit
parent d6e0dca1d5
commit 7621dd771c
1 changed files with 12 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
drivers/net/ice/base/ice_common.c
View File

@ -2054,40 +2054,21 @@ ice_discover_caps(struct ice_hw *hw, enum ice_adminq_opc opc)
{ {
enum ice_status status; enum ice_status status;
u32 cap_count; u32 cap_count;
u16 cbuf_len; void *cbuf;
u8 retries;
/* The driver doesn't know how many capabilities the device will return cbuf = ice_malloc(hw, ICE_AQ_MAX_BUF_LEN);
* so the buffer size required isn't known ahead of time. The driver if (!cbuf)
* starts with cbuf_len and if this turns out to be insufficient, the return ICE_ERR_NO_MEMORY;
* device returns ICE_AQ_RC_ENOMEM and also the cap_count it needs.
* The driver then allocates the buffer based on the count and retries /* Although the driver doesn't know the number of capabilities the
* the operation. So it follows that the retry count is 2. * device will return, we can simply send a 4KB buffer, the maximum
* possible size that firmware can return.
*/ */
#define ICE_GET_CAP_BUF_COUNT 40 cap_count = ICE_AQ_MAX_BUF_LEN / sizeof(struct ice_aqc_list_caps_elem);
#define ICE_GET_CAP_RETRY_COUNT 2
cap_count = ICE_GET_CAP_BUF_COUNT; status = ice_aq_discover_caps(hw, cbuf, ICE_AQ_MAX_BUF_LEN, &cap_count,
retries = ICE_GET_CAP_RETRY_COUNT; opc, NULL);
ice_free(hw, cbuf);
do {
void *cbuf;
cbuf_len = (u16)(cap_count *
sizeof(struct ice_aqc_list_caps_elem));
cbuf = ice_malloc(hw, cbuf_len);
if (!cbuf)
return ICE_ERR_NO_MEMORY;
status = ice_aq_discover_caps(hw, cbuf, cbuf_len, &cap_count,
opc, NULL);
ice_free(hw, cbuf);
if (!status || hw->adminq.sq_last_status != ICE_AQ_RC_ENOMEM)
break;
/* If ENOMEM is returned, try again with bigger buffer */
} while (--retries);
return status; return status;
} }