d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

igb/ixgbe: ETH_MQ_RX_NONE should disable RSS

Browse Source 
As explained in rte_ethdev.h, ETH_MQ_RX_NONE allows to not choose RSS, DCB
or VMDQ mode.

But the igb/ixgbe code always silently select the RSS mode with ETH_MQ_RX_NONE.
This patch fixes this incoherence between the API and the implementation.

Signed-off-by: Maxime Leroy <maxime.leroy@6wind.com>
Acked-by: Ivan Boule <ivan.boule@6wind.com>
This commit is contained in:
Maxime Leroy 2013-09-02 17:07:55 +02:00 committed by David Marchand
parent a18dc3319e
commit 7a9b2b0998
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/librte_pmd_e1000/igb_rxtx.c
View File

@ -1755,8 +1755,6 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev)
*/ */
if (dev->data->nb_rx_queues > 1) if (dev->data->nb_rx_queues > 1)
switch (dev->data->dev_conf.rxmode.mq_mode) { switch (dev->data->dev_conf.rxmode.mq_mode) {
case ETH_MQ_RX_NONE:
/* if mq_mode not assign, we use rss mode.*/
case ETH_MQ_RX_RSS: case ETH_MQ_RX_RSS:
igb_rss_configure(dev); igb_rss_configure(dev);
break; break;
@ -1764,6 +1762,8 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev)
/*Configure general VMDQ only RX parameters*/ /*Configure general VMDQ only RX parameters*/
igb_vmdq_rx_hw_configure(dev); igb_vmdq_rx_hw_configure(dev);
break; break;
case ETH_MQ_RX_NONE:
/* if mq_mode is none, disable rss mode.*/
default: default:
igb_rss_disable(dev); igb_rss_disable(dev);
break; break;

4
lib/librte_pmd_ixgbe/ixgbe_rxtx.c
View File

@ -3228,8 +3228,6 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
*/ */
if (dev->data->nb_rx_queues > 1) if (dev->data->nb_rx_queues > 1)
switch (dev->data->dev_conf.rxmode.mq_mode) { switch (dev->data->dev_conf.rxmode.mq_mode) {
case ETH_MQ_RX_NONE:
/* if mq_mode not assign, we use rss mode.*/
case ETH_MQ_RX_RSS: case ETH_MQ_RX_RSS:
ixgbe_rss_configure(dev); ixgbe_rss_configure(dev);
break; break;
@ -3242,6 +3240,8 @@ ixgbe_dev_mq_rx_configure(struct rte_eth_dev *dev)
ixgbe_vmdq_rx_hw_configure(dev); ixgbe_vmdq_rx_hw_configure(dev);
break; break;
case ETH_MQ_RX_NONE:
/* if mq_mode is none, disable rss mode.*/
default: ixgbe_rss_disable(dev); default: ixgbe_rss_disable(dev);
} }
else else