d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/testpmd: fix return of port list parser

Browse Source 
The function parse_port_list() is designed to return
unsigned int value. After sanitizing the inputs,
it is returning -1. Changed it to return 0.

Fixes: 2df00d562d ("app/testpmd: add --portlist option")

Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
This commit is contained in:
Hariprasad Govindharajan 2020-02-20 17:39:03 +00:00 committed by Ferruh Yigit
parent 35594a9b6f
commit 7eeda4d55a
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
app/test-pmd/config.c
View File

@ -2616,9 +2616,6 @@ set_fwd_ports_list(unsigned int *portlist, unsigned int nb_pt)
* If the user wants to use only the ports 1,2 then the input
* is 1,2.
* valid characters are '-' and ','
* invalid chars like '.' or '#' will result in
* EAL: Error - exiting with code: 1
* Cause: Invalid fwd port list
* @param[out] values
* This array will be filled with a list of port IDs
* based on the user input
@ -2630,7 +2627,8 @@ set_fwd_ports_list(unsigned int *portlist, unsigned int nb_pt)
* 1) Number of elements in the values array
* 2) Maximum value of each element in the values array
* @return
* -returns total count of parsed port IDs
* On success, returns total count of parsed port IDs
* On failure, returns 0
*/
static unsigned int
parse_port_list(const char *list, unsigned int *values, unsigned int maxsize)
@ -2642,7 +2640,7 @@ parse_port_list(const char *list, unsigned int *values, unsigned int maxsize)
unsigned int marked[maxsize];
if (list == NULL || values == NULL)
return -1;
return 0;
for (i = 0; i < (int)maxsize; i++)
marked[i] = 0;