d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/hns3: ignore function return on reset error path

Browse Source 
There is a coverity defect related "Unchecked return value".

The internal static hns3_reset_err_handle function is reset error
process of hns3 PMD driver. If failure in reset process, it does not
mean that the network port is completely unavailable, so the command
interface between driver and firmware still needs to be initialized.
Regardless of whether the execution of the function named hns3_cmd_init
is successful or not, the next process after execution must be
continued, so there is no need to check the return value. If
hns3_cmd_init fails to execute, there will be corresponding log
information inside hns3_cmd_init.

This patch adds '(void)' Type conversion to avoid coverity warning.

Coverity issue: 349934
Fixes: 2790c6464725 ("net/hns3: support device reset")
Cc: stable@dpdk.org

Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
This commit is contained in:
Hongbo Zheng 2020-06-09 16:44:15 +08:00 committed by Ferruh Yigit
parent 41b966ffb4
commit 80cd38e1b5
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/hns3/hns3_intr.c
View File

@ -882,8 +882,14 @@ hns3_reset_err_handle(struct hns3_adapter *hns)
return true;
}
/*
* Failure to reset does not mean that the network port is
* completely unavailable, so cmd still needs to be initialized.
* Regardless of whether the execution is successful or not, the
* flow after execution must be continued.
*/
if (rte_atomic16_read(&hw->reset.disable_cmd))
hns3_cmd_init(hw);
(void)hns3_cmd_init(hw);
reset_fail:
hw->reset.attempts = 0;
hw->reset.stats.fail_cnt++;