d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/hns3: fix queue state after reset

Browse Source 
FLR operation will reset the queue enabling state and
the driver needs to restore the state after reset.
If the driver does not restore the state, it will result
in unpredictable behavior with reset when user start or
stop queue by calling the relevant function if.

This patch fix it by add a queue enabling state restore
function to the reset handler.

Fixes: fa29fe45a7 ("net/hns3: support queue start and stop")
Cc: stable@dpdk.org

Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
This commit is contained in:
Chengchang Tang 2020-11-09 22:29:01 +08:00 committed by Ferruh Yigit
parent 6dd32ded17
commit 80ec1bbd5b
4 changed files with 31 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/hns3/hns3_ethdev.c
View File

@ -5570,6 +5570,11 @@ hns3_start_service(struct hns3_adapter *hns)
/* Enable interrupt of all rx queues before enabling queues */
hns3_dev_all_rx_queue_intr_enable(hw, true);
/*
* Enable state of each rxq and txq will be recovered after
* reset, so we need to restore them before enable all tqps;
*/
hns3_restore_tqp_enable_state(hw);
/*
* When finished the initialization, enable queues to receive
* and transmit packets.

5
drivers/net/hns3/hns3_ethdev_vf.c
View File

@ -2423,6 +2423,11 @@ hns3vf_start_service(struct hns3_adapter *hns)
/* Enable interrupt of all rx queues before enabling queues */
hns3_dev_all_rx_queue_intr_enable(hw, true);
/*
* Enable state of each rxq and txq will be recovered after
* reset, so we need to restore them before enable all tqps;
*/
hns3_restore_tqp_enable_state(hw);
/*
* When finished the initialization, enable queues to receive
* and transmit packets.

20
drivers/net/hns3/hns3_rxtx.c
View File

@ -502,6 +502,26 @@ hns3_start_all_rxqs(struct rte_eth_dev *dev)
return -EINVAL;
}
void
hns3_restore_tqp_enable_state(struct hns3_hw *hw)
{
struct hns3_rx_queue *rxq;
struct hns3_tx_queue *txq;
uint16_t i;
for (i = 0; i < hw->data->nb_rx_queues; i++) {
rxq = hw->data->rx_queues[i];
if (rxq != NULL)
hns3_enable_rxq(rxq, rxq->enabled);
}
for (i = 0; i < hw->data->nb_tx_queues; i++) {
txq = hw->data->tx_queues[i];
if (txq != NULL)
hns3_enable_txq(txq, txq->enabled);
}
}
void
hns3_stop_all_txqs(struct rte_eth_dev *dev)
{

1
drivers/net/hns3/hns3_rxtx.h
View File

@ -677,5 +677,6 @@ uint32_t hns3_get_tqp_reg_offset(uint16_t idx);
int hns3_start_all_txqs(struct rte_eth_dev *dev);
int hns3_start_all_rxqs(struct rte_eth_dev *dev);
void hns3_stop_all_txqs(struct rte_eth_dev *dev);
void hns3_restore_tqp_enable_state(struct hns3_hw *hw);
#endif /* _HNS3_RXTX_H_ */