d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/testpmd: fix memory access error for metering CLI

Browse Source 
Fix memory access (out of bounds write) error, color and
action assignments.

Coverity issue: 198437
Fixes: 30ffb4e67ee3 ("app/testpmd: add commands traffic metering and policing")

Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
This commit is contained in:
Jasvinder Singh 2017-10-27 10:17:35 +01:00 committed by Ferruh Yigit
parent 4f5dd001f7
commit 860806fc7b
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/test-pmd/cmdline_mtr.c
View File

@ -802,17 +802,15 @@ static void cmd_set_port_meter_policer_action_parsed(void *parsed_result,
color = RTE_MTR_GREEN;
else if (strcmp(c, "Y") == 0)
color = RTE_MTR_YELLOW;
else if (strcmp(c, "Y") == 0)
color = RTE_MTR_RED;
else
color = RTE_MTR_COLORS;
color = RTE_MTR_RED;
/* Action */
if (strcmp(a, "G") == 0)
action[color] = MTR_POLICER_ACTION_COLOR_GREEN;
else if (strcmp(a, "Y") == 0)
action[color] = MTR_POLICER_ACTION_COLOR_YELLOW;
else if (strcmp(a, "Y") == 0)
else if (strcmp(a, "R") == 0)
action[color] = MTR_POLICER_ACTION_COLOR_RED;
else
action[color] = MTR_POLICER_ACTION_DROP;