d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/ice: use relaxed and remove duplicate barrier

Browse Source 
To guarantee the orderings of successive stores to CIO and MMIO memory,
a lighter weight rte_io_wmb [1] can be used instead of rte_wmb, and since
the ICE_PCI_REG_WRITE API already has an inclusive rte_io_wmb, this
explicit call can even be saved.

[1] http://git.dpdk.org/dpdk/tree/lib/librte_eal/common/include/generic/
rte_atomic.h#n98

Signed-off-by: Gavin Hu <gavin.hu@arm.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
This commit is contained in:
Gavin Hu 2019-09-16 19:27:15 +08:00 committed by Ferruh Yigit
parent 3779a64ecd
commit 8669e6ae05
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/ice/ice_rxtx.c
View File

@ -402,8 +402,6 @@ ice_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
return -ENOMEM; return -ENOMEM;
} }
rte_wmb();
/* Init the RX tail register. */ /* Init the RX tail register. */
ICE_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1); ICE_PCI_REG_WRITE(rxq->qrx_tail, rxq->nb_rx_desc - 1);
@ -1275,7 +1273,6 @@ ice_rx_alloc_bufs(struct ice_rx_queue *rxq)
} }
/* Update rx tail regsiter */ /* Update rx tail regsiter */
rte_wmb();
ICE_PCI_REG_WRITE(rxq->qrx_tail, rxq->rx_free_trigger); ICE_PCI_REG_WRITE(rxq->qrx_tail, rxq->rx_free_trigger);
rxq->rx_free_trigger = rxq->rx_free_trigger =
@ -2177,8 +2174,6 @@ ice_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
ICE_TXD_QW1_CMD_S); ICE_TXD_QW1_CMD_S);
} }
end_of_tx: end_of_tx:
rte_wmb();
/* update Tail register */ /* update Tail register */
ICE_PCI_REG_WRITE(txq->qtx_tail, tx_id); ICE_PCI_REG_WRITE(txq->qtx_tail, tx_id);
txq->tx_tail = tx_id; txq->tx_tail = tx_id;
@ -2334,7 +2329,6 @@ tx_xmit_pkts(struct ice_tx_queue *txq,
txq->tx_tail = 0; txq->tx_tail = 0;
/* Update the tx tail register */ /* Update the tx tail register */
rte_wmb();
ICE_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail); ICE_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail);
return nb_pkts; return nb_pkts;