d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/hns3: fix unchecked return value

Browse Source 
There are coverity defects related "calling
hns3_reset_all_tqps without checking return value
in hns3_do_start".

This patch fixes the warning by add "void" declaration
because here is exception handling, hns3_reset_all_tqps
will have the corresponding error message if it is
handled incorrectly, so it is not necessary to check
hns3_reset_all_tqps return value, here keep ret as the
error code causing the exception.

Coverity issue: 363048
Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop")
Cc: stable@dpdk.org

Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Lijun Ou <oulijun@huawei.com>
This commit is contained in:
Hongbo Zheng 2020-10-29 20:51:53 +08:00 committed by Ferruh Yigit
parent 0e98d5e6d9
commit 8a2d3bd64c
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/hns3/hns3_ethdev.c
View File

@ -4752,7 +4752,13 @@ hns3_do_start(struct hns3_adapter *hns, bool reset_queue)
err_config_mac_mode:
hns3_dev_release_mbufs(hns);
hns3_reset_all_tqps(hns);
/*
* Here is exception handling, hns3_reset_all_tqps will have the
* corresponding error message if it is handled incorrectly, so it is
* not necessary to check hns3_reset_all_tqps return value, here keep
* ret as the error code causing the exception.
*/
(void)hns3_reset_all_tqps(hns);
return ret;
}