d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

vhost: remove async batch threshold

Browse Source 
Reaching the async batch threshold was one of the condition
to trigger the DMA transfer. However, this condition was
never met since the threshold value is 32, same as the
MAX_PKT_BURST value.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Reviewed-by: Jiayu Hu <jiayu.hu@intel.com>
This commit is contained in:
Maxime Coquelin 2021-10-26 18:28:54 +02:00
parent 3fe629547e
commit 8b3fc5a213
1 changed files with 4 additions and 10 deletions

14
lib/vhost/virtio_net.c

@ -25,8 +25,6 @@
#define MAX_BATCH_LEN 256
#define VHOST_ASYNC_BATCH_THRESHOLD 32
static __rte_always_inline bool
rxvq_is_mergeable(struct virtio_net *dev)
{
@ -1565,12 +1563,10 @@ virtio_dev_rx_async_submit_split(struct virtio_net *dev,
vq->last_avail_idx += num_buffers;
/*
* conditions to trigger async device transfer:
* - buffered packet number reaches transfer threshold
* condition to trigger async device transfer:
* - unused async iov number is less than max vhost vector
*/
if (unlikely(pkt_burst_idx >= VHOST_ASYNC_BATCH_THRESHOLD ||
(VHOST_MAX_ASYNC_VEC - iovec_idx < BUF_VECTOR_MAX))) {
if (unlikely(VHOST_MAX_ASYNC_VEC - iovec_idx < BUF_VECTOR_MAX)) {
n_xfer = async->ops.transfer_data(dev->vid,
queue_id, tdes, 0, pkt_burst_idx);
if (likely(n_xfer >= 0)) {
@ -1864,12 +1860,10 @@ virtio_dev_rx_async_submit_packed(struct virtio_net *dev,
vq_inc_last_avail_packed(vq, num_descs);
/*
* conditions to trigger async device transfer:
* - buffered packet number reaches transfer threshold
* condition to trigger async device transfer:
* - unused async iov number is less than max vhost vector
*/
if (unlikely(pkt_burst_idx >= VHOST_ASYNC_BATCH_THRESHOLD ||
(VHOST_MAX_ASYNC_VEC - iovec_idx < BUF_VECTOR_MAX))) {
if (unlikely(VHOST_MAX_ASYNC_VEC - iovec_idx < BUF_VECTOR_MAX)) {
n_xfer = async->ops.transfer_data(dev->vid,
queue_id, tdes, 0, pkt_burst_idx);
if (likely(n_xfer >= 0)) {