d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

test/telemetry: fix error handling for socket

Browse Source 
When the socket connection failed, an error was printed to screen but
the function did not return an error, and continued to try read from the
socket. This is now corrected to close the socket and return -1 when the
connection fails.

Fixes: bd78cf693ebd ("test/telemetry: add unit tests for data to JSON")

Signed-off-by: Ciara Power <ciara.power@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
This commit is contained in:
Ciara Power 2020-10-13 17:28:20 +01:00 committed by Thomas Monjalon
parent 1e6a661302
commit 8b4a23f115
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
app/test/test_telemetry_data.c
View File

@ -319,9 +319,12 @@ connect_to_socket(void)
"%s/dpdk_telemetry.%s", rte_eal_get_runtime_dir(),
TELEMETRY_VERSION);
if (connect(sock, (struct sockaddr *) &telem_addr,
sizeof(telem_addr)) < 0)
sizeof(telem_addr)) < 0) {
printf("\n%s: Error connecting to socket: %s\n", __func__,
strerror(errno));
close(sock);
return -1;
}
bytes = read(sock, buf, sizeof(buf) - 1);
if (bytes < 0) {