d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/virtio: fix buffer leak on VLAN insert

Browse Source 
The function rte_vlan_insert may allocate a new buffer for the
vlan header and return a different mbuf than originally passed.
In this case, the stored mbuf in txm[] array could point to wrong
buffer.

Fixes: dd856dfcb9 ("virtio: use any layout on Tx")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
This commit is contained in:
Stephen Hemminger 2019-04-05 09:31:15 -07:00 committed by Ferruh Yigit
parent fd4fa52cbf
commit 8f37e38241
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/virtio/virtio_rxtx.c
View File

@ -2003,6 +2003,8 @@ virtio_xmit_pkts_packed(void *tx_queue, struct rte_mbuf **tx_pkts,
rte_pktmbuf_free(txm);
continue;
}
/* vlan_insert may add a header mbuf */
tx_pkts[nb_tx] = txm;
}
/* optimize ring usage */
@ -2090,6 +2092,8 @@ virtio_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
rte_pktmbuf_free(txm);
continue;
}
/* vlan_insert may add a header mbuf */
tx_pkts[nb_tx] = txm;
}
/* optimize ring usage */
@ -2193,6 +2197,8 @@ virtio_xmit_pkts_inorder(void *tx_queue,
rte_pktmbuf_free(txm);
continue;
}
/* vlan_insert may add a header mbuf */
tx_pkts[nb_tx] = txm;
}
/* optimize ring usage */