d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

distributor: fix livelock on flush

Browse Source 
The Distributor autotest can lock if ran enough times. Worker and
distributor threads get into a livelock situation waiting on each
other.

To repeat:
`while sudo sh -c "echo 'distributor_autotest' |
		./build/app/test/dpdk-test"; do :; done`

The root cause is where we are flushing on exit, and do not wait for
all worker packets to be returned before exiting.
Add a delay on flush so that all worker packets are returned before
completing the flush.

Bugzilla ID: 316
Fixes: 775003ad2f ("distributor: add new burst-capable library")
Cc: stable@dpdk.org

Reported-by: Michael Santana <msantana@redhat.com>
Signed-off-by: David Hunt <david.hunt@intel.com>
Signed-off-by: Liang Ma <liang.j.ma@intel.com>
Tested-by: Michael Santana <msantana@redhat.com>
This commit is contained in:
Liang Ma 2019-07-25 10:03:01 +01:00 committed by Thomas Monjalon
parent 54ad947eda
commit 96c343868d
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/librte_distributor/rte_distributor.c
View File

@ -542,6 +542,9 @@ rte_distributor_flush_v1705(struct rte_distributor *d)
while (total_outstanding(d) > 0)
rte_distributor_process(d, NULL, 0);
/* wait 10ms to allow all worker drain the pkts */
rte_delay_us(10000);
/*
* Send empty burst to all workers to allow them to exit
* gracefully, should they need to.