d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

log: remove unnecessary stubs

Browse Source 
The read/seek/close stub functions are unnecessary on the
log stream.  Per glibc fopencookie man page:

       cookie_read_function_t *read
              If *read is a null pointer, then reads from  the  custom  stream
              always return end of file.

       cookie_seek_function_t *seek
              If *seek is a null pointer, then it is not possible  to  perform
              seek operations on the stream.

       cookie_close_function_t *close
              If  *close is NULL, then no special action is performed when the
              stream is closed.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>
This commit is contained in:
Stephen Hemminger 2014-12-09 08:35:46 -08:00 committed by Thomas Monjalon
parent 8cf8fe6c3e
commit 985cba0c5c
1 changed files with 0 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
lib/librte_eal/linuxapp/eal/eal_log.c
View File

@ -83,33 +83,8 @@ console_log_write(__attribute__((unused)) void *c, const char *buf, size_t size)
return ret;
}
static ssize_t
console_log_read(__attribute__((unused)) void *c,
__attribute__((unused)) char *buf,
__attribute__((unused)) size_t size)
{
return 0;
}
static int
console_log_seek(__attribute__((unused)) void *c,
__attribute__((unused)) off64_t *offset,
__attribute__((unused)) int whence)
{
return -1;
}
static int
console_log_close(__attribute__((unused)) void *c)
{
return 0;
}
static cookie_io_functions_t console_log_func = {
.read = console_log_read,
.write = console_log_write,
.seek = console_log_seek,
.close = console_log_close
};
/*
@ -150,33 +125,8 @@ early_log_write(__attribute__((unused)) void *c, const char *buf, size_t size)
return ret;
}
static ssize_t
early_log_read(__attribute__((unused)) void *c,
__attribute__((unused)) char *buf,
__attribute__((unused)) size_t size)
{
return 0;
}
static int
early_log_seek(__attribute__((unused)) void *c,
__attribute__((unused)) off64_t *offset,
__attribute__((unused)) int whence)
{
return -1;
}
static int
early_log_close(__attribute__((unused)) void *c)
{
return 0;
}
static cookie_io_functions_t early_log_func = {
.read = early_log_read,
.write = early_log_write,
.seek = early_log_seek,
.close = early_log_close
};
static FILE *early_log_stream;