d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/netvsc: fix chimney buffer size error handling

Browse Source 
Fix the error handling in setting up transmit buffer.
If setting up chimney buffer fails, then it is not connected so
no need to send disconnect.

Allow for some unused area if full area is not used.

Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
This commit is contained in:
Stephen Hemminger 2018-08-09 10:50:05 -07:00 committed by Ferruh Yigit
parent 763e450ae2
commit 99e3d0e72f
1 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/net/netvsc/hn_nvs.c
View File

@ -279,14 +279,13 @@ hn_nvs_conn_chim(struct hn_data *hv)
NVS_TYPE_CHIM_CONNRESP);
if (error) {
PMD_DRV_LOG(ERR, "exec nvs chim conn failed");
goto cleanup;
return error;
}
if (resp.status != NVS_STATUS_OK) {
PMD_DRV_LOG(ERR, "nvs chim conn failed: %x",
resp.status);
error = -EIO;
goto cleanup;
return -EIO;
}
sectsz = resp.sectsz;
@ -295,7 +294,8 @@ hn_nvs_conn_chim(struct hn_data *hv)
PMD_DRV_LOG(NOTICE,
"invalid chimney sending buffer section size: %u",
sectsz);
return 0;
error = -EINVAL;
goto cleanup;
}
hv->chim_szmax = sectsz;
@ -304,11 +304,6 @@ hn_nvs_conn_chim(struct hn_data *hv)
PMD_DRV_LOG(INFO, "send buffer %lu section size:%u, count:%u",
len, hv->chim_szmax, hv->chim_cnt);
if (len % hv->chim_szmax != 0) {
PMD_DRV_LOG(NOTICE,
"chimney sending sections are not properly aligned");
}
/* Done! */
return 0;