d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

vhost/crypto: check request pointer before dereference

Browse Source 
Use vc_req only after it was checked not to be NULL.

Fixes: 2d962bb736 ("vhost/crypto: fix possible TOCTOU attack")
Cc: stable@dpdk.org

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
This commit is contained in:
Thierry Herbelot 2021-05-24 11:08:21 +02:00 committed by Chenbo Xia
parent 2d333c4ac3
commit 9cfbe67691
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/vhost/vhost_crypto.c
View File

@ -1337,13 +1337,15 @@ vhost_crypto_finalize_one_request(struct rte_crypto_op *op,
struct rte_mbuf *m_src = op->sym->m_src;
struct rte_mbuf *m_dst = op->sym->m_dst;
struct vhost_crypto_data_req *vc_req = rte_mbuf_to_priv(m_src);
struct vhost_virtqueue *vq = vc_req->vq;
uint16_t used_idx = vc_req->desc_idx, desc_idx;
struct vhost_virtqueue *vq;
uint16_t used_idx, desc_idx;
if (unlikely(!vc_req)) {
VC_LOG_ERR("Failed to retrieve vc_req");
return NULL;
}
vq = vc_req->vq;
used_idx = vc_req->desc_idx;
if (old_vq && (vq != old_vq))
return vq;