d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/nfp: fix dangling pointer on probe failure

Browse Source 
When nfp_pf_create_dev() is cleaning up, it does not correctly set
the dev_private variable to NULL, which will lead to a double free.

Fixes: ef28aa96e53b ("net/nfp: support multiprocess")
Cc: stable@dpdk.org

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Acked-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
This commit is contained in:
Yunjian Wang 2020-04-07 19:37:27 +08:00 committed by Ferruh Yigit
parent 735d826e6c
commit 9d5996c01d
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/nfp/nfp_net.c
View File

@ -3451,9 +3451,10 @@ nfp_pf_create_dev(struct rte_pci_device *dev, int port, int ports,
probe_failed:
rte_free(port_name);
/* free ports private data if primary process */
if (rte_eal_process_type() == RTE_PROC_PRIMARY)
if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
rte_free(eth_dev->data->dev_private);
eth_dev->data->dev_private = NULL;
}
rte_eth_dev_release_port(eth_dev);
return retval;