d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/octeontx: fix memory leak of MAC address table

Browse Source 
MAC address table is allocated during octeontx device create and
same is used to maintain list of MAC address associated to port.
This table is not getting freed niether in case of error nor during
graceful shutdown of port.

Patch fixes memory required memory for both the cases as mentioned.

Fixes: f18b146c49 ("net/octeontx: create ethdev ports")
Cc: stable@dpdk.org

Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
Acked-by: Harman Kalra <hkalra@marvell.com>
This commit is contained in:
Sunil Kumar Kori 2020-01-29 14:47:04 +05:30 committed by Ferruh Yigit
parent 184a323573
commit 9e399b88ce
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/octeontx/octeontx_ethdev.c
View File

@ -351,6 +351,10 @@ octeontx_dev_close(struct rte_eth_dev *dev)
rte_free(txq);
}
/* Free MAC address table */
rte_free(dev->data->mac_addrs);
dev->data->mac_addrs = NULL;
dev->tx_pkt_burst = NULL;
dev->rx_pkt_burst = NULL;
}
@ -1143,7 +1147,7 @@ octeontx_create(struct rte_vdev_device *dev, int port, uint8_t evdev,
octeontx_log_err("eth_dev->port_id (%d) is diff to orig (%d)",
data->port_id, nic->port_id);
res = -EINVAL;
goto err;
goto free_mac_addrs;
}
/* Update port_id mac to eth_dev */
@ -1162,6 +1166,8 @@ octeontx_create(struct rte_vdev_device *dev, int port, uint8_t evdev,
rte_eth_dev_probing_finish(eth_dev);
return data->port_id;
free_mac_addrs:
rte_free(data->mac_addrs);
err:
if (nic)
octeontx_port_close(nic);