d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

flow_classify: mark library as deprecated

Browse Source 
This library has no maintainer and, for now, nobody expressed interest
in taking over.
Mark this experimental library as deprecated and announce plan for
removal in v23.11.

Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Acked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
This commit is contained in:
David Marchand 2022-10-27 11:46:55 +02:00
parent 2993c839f5
commit 9f81548430
6 changed files with 24 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MAINTAINERS
View File

@ -1453,7 +1453,7 @@ F: doc/guides/prog_guide/ipsec_lib.rst
M: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
F: app/test-sad/
Flow Classify - EXPERIMENTAL
Flow Classify - EXPERIMENTAL - UNMAINTAINED
F: lib/flow_classify/
F: app/test/test_flow_classify*
F: doc/guides/prog_guide/flow_classify_lib.rst

9
doc/guides/prog_guide/flow_classify_lib.rst
View File

@ -4,6 +4,15 @@
Flow Classification Library
===========================
.. note::
The Flow Classification library is deprecated and will be removed in future.
See :doc:`../rel_notes/deprecation`.
It is disabled by default in the DPDK build.
To re-enable the library, remove 'flow_classify' from the "disable_libs"
meson option when configuring a build.
DPDK provides a Flow Classification library that provides the ability
to classify an input packet by matching it against a set of Flow rules.

6
doc/guides/rel_notes/deprecation.rst
View File

@ -96,3 +96,9 @@ Deprecation Notices
to have another parameter ``qp_id`` to return the queue pair ID
which got error interrupt to the application,
so that application can reset that particular queue pair.
* flow_classify: The flow_classify library and example have no maintainer.
The library is experimental and, as such, it could be removed from DPDK.
Its removal has been postponed to let potential users report interest
in maintaining it.
In the absence of such interest, this library will be removed in DPDK 23.11.

3
lib/flow_classify/rte_flow_classify.c
View File

@ -259,6 +259,9 @@ rte_flow_classifier_create(struct rte_flow_classifier_params *params)
struct rte_flow_classifier *cls;
int ret;
RTE_FLOW_CLASSIFY_LOG(WARNING,
"WARNING: flow_classify is deprecated and will be removed in DPDK 23.11\n");
/* Check input parameters */
ret = rte_flow_classifier_check_params(params);
if (ret != 0) {

5
lib/meson.build
View File

@ -85,7 +85,10 @@ optional_libs = [
'vhost',
]
dpdk_libs_deprecated += ['kni']
dpdk_libs_deprecated += [
'flow_classify',
'kni',
]
disabled_libs = []
opt_disabled_libs = run_command(list_dir_globs, get_option('disable_libs'),

2
meson_options.txt
View File

@ -10,7 +10,7 @@ option('disable_apps', type: 'string', value: '', description:
'Comma-separated list of apps to explicitly disable.')
option('disable_drivers', type: 'string', value: '', description:
'Comma-separated list of drivers to explicitly disable.')
option('disable_libs', type: 'string', value: 'kni', description:
option('disable_libs', type: 'string', value: 'flow_classify,kni', description:
'Comma-separated list of libraries to explicitly disable. [NOTE: not all libs can be disabled]')
option('drivers_install_subdir', type: 'string', value: 'dpdk/pmds-<VERSION>', description:
'Subdirectory of libdir where to install PMDs. Defaults to using a versioned subdirectory.')