d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

raw/ioat: fix termination descriptor for batch

Browse Source 
When batch_size == 1, idxd has to add a dummy termination descriptor
to satisfy HW requirements.
Right now it uses NOP descriptor with FENCE flag.
This is excessive and fencing can slowdown things quite significantly.
The patch removes FENCE flag from termination dummy descriptor.
That helps to improve performance for no-burst scenarios.

Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs")

Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
This commit is contained in:
Konstantin Ananyev 2021-07-16 14:50:27 +01:00 committed by David Marchand
parent 9cf9ac48b1
commit a03e4b62a7
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
drivers/raw/ioat/rte_idxd_rawdev_fns.h
View File

@ -231,6 +231,14 @@ __idxd_enqueue_copy(int dev_id, rte_iova_t src, rte_iova_t dst,
src, dst, length, &hdl);
}
static __rte_always_inline int
__idxd_enqueue_nop(int dev_id)
{
/* only op field needs filling - zero src, dst and length */
return __idxd_write_desc(dev_id, idxd_op_nop << IDXD_CMD_OP_SHIFT,
0, 0, 0, NULL);
}
static __rte_always_inline int
__idxd_fence(int dev_id)
{
@ -260,8 +268,8 @@ __idxd_perform_ops(int dev_id)
return 0;
if (idxd->batch_size == 1)
/* use a fence as a null descriptor, so batch_size >= 2 */
if (__idxd_fence(dev_id) != 1)
/* use a NOP as a null descriptor, so batch_size >= 2 */
if (__idxd_enqueue_nop(dev_id) != 1)
return -1;
/* write completion beyond last desc in the batch */