d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/virtio: fix variable assignment in helper macro

Browse Source 
Inside Macro ASSIGN_UNLESS_EQUAL(var, val), assignment to var is always
failing as assignment done using var_ having local scope only.
This leads to TX packets not going out and found broken due to cleanup
malfunctioning. This patch fixes the wrong variable assignment.

Fixes: 57f90f894588 ("net/virtio: reuse packed ring functions")
Cc: stable@dpdk.org

Signed-off-by: Vipul Ashri <vipul.ashri@oracle.com>
Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
This commit is contained in:
Vipul Ashri 2020-09-18 15:25:04 +05:30 committed by Ferruh Yigit
parent 4fb86eb5e8
commit a1412e05ca
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/net/virtio/virtqueue.h
View File

@ -607,10 +607,10 @@ virtqueue_notify(struct virtqueue *vq)
/* avoid write operation when necessary, to lessen cache issues */
#define ASSIGN_UNLESS_EQUAL(var, val) do { \
typeof(var) var_ = (var); \
typeof(val) val_ = (val); \
if ((var_) != (val_)) \
(var_) = (val_); \
typeof(var) *const var_ = &(var); \
typeof(val) const val_ = (val); \
if (*var_ != val_) \
*var_ = val_; \
} while (0)
#define virtqueue_clear_net_hdr(hdr) do { \