d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

examples/l3fwd-power: exit on power lib init failure

Browse Source 
Currently, if power library initialization fails, only a log message is
displayed. This is suboptimal for a number of reasons, but the main one
is that telemetry mode does not depend on the power library and can
therefore run in environments where l3fwd-power would normally not run
correctly (such as inside a VM). This will lead to attempts to
deinitialize the power library on exit, with a subsequent forced unclean
shutdown of DPDK.

Fix this by only initializing the power library in modes that actually
need it, and change a log message to a failure to initialize.

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
This commit is contained in:
Anatoly Burakov 2020-04-20 17:56:51 +00:00 committed by Thomas Monjalon
parent 97fbfe5a95
commit a163130bd6
1 changed files with 11 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
examples/l3fwd-power/main.c
View File

@ -2065,15 +2065,17 @@ static int check_ptype(uint16_t portid)
static int static int
init_power_library(void) init_power_library(void)
{ {
int ret = 0, lcore_id; unsigned int lcore_id;
for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) { int ret = 0;
if (rte_lcore_is_enabled(lcore_id)) {
/* init power management library */ RTE_LCORE_FOREACH(lcore_id) {
ret = rte_power_init(lcore_id); /* init power management library */
if (ret) ret = rte_power_init(lcore_id);
RTE_LOG(ERR, POWER, if (ret) {
RTE_LOG(ERR, POWER,
"Library initialization failed on core %u\n", "Library initialization failed on core %u\n",
lcore_id); lcore_id);
return ret;
} }
} }
return ret; return ret;
@ -2224,8 +2226,8 @@ main(int argc, char **argv)
if (ret < 0) if (ret < 0)
rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n"); rte_exit(EXIT_FAILURE, "Invalid L3FWD parameters\n");
if (init_power_library()) if (app_mode != APP_MODE_TELEMETRY && init_power_library())
RTE_LOG(ERR, L3FWD_POWER, "init_power_library failed\n"); rte_exit(EXIT_FAILURE, "init_power_library failed\n");
if (update_lcore_params() < 0) if (update_lcore_params() < 0)
rte_exit(EXIT_FAILURE, "update_lcore_params failed\n"); rte_exit(EXIT_FAILURE, "update_lcore_params failed\n");