d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

kni: optimize Rx burst size computation

Browse Source 
No reason to check out many entries are in kni->rx_q prior to
actually pulling them from the fifo. You can't dequeue more than
are there anyway. Max entries to dequeue is either the max batch
size or however much space is available on kni->free_q (lesser of the two).

Signed-off-by: Jay Rolette <rolette@infiniteio.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>
This commit is contained in:
Jay Rolette 2015-06-03 14:18:56 -05:00 committed by Thomas Monjalon
parent da9cc0b9df
commit a1f8789546
1 changed files with 8 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
lib/librte_eal/linuxapp/kni/kni_net.c
View File

@ -131,7 +131,7 @@ kni_net_rx_normal(struct kni_dev *kni)
{ {
unsigned ret; unsigned ret;
uint32_t len; uint32_t len;
unsigned i, num, num_rq, num_fq; unsigned i, num, num_fq;
struct rte_kni_mbuf *kva; struct rte_kni_mbuf *kva;
struct rte_kni_mbuf *va[MBUF_BURST_SZ]; struct rte_kni_mbuf *va[MBUF_BURST_SZ];
void * data_kva; void * data_kva;
@ -139,24 +139,19 @@ kni_net_rx_normal(struct kni_dev *kni)
struct sk_buff *skb; struct sk_buff *skb;
struct net_device *dev = kni->net_dev; struct net_device *dev = kni->net_dev;
/* Get the number of entries in rx_q */
num_rq = kni_fifo_count(kni->rx_q);
/* Get the number of free entries in free_q */ /* Get the number of free entries in free_q */
num_fq = kni_fifo_free_count(kni->free_q); if ((num_fq = kni_fifo_free_count(kni->free_q)) == 0) {
/* No room on the free_q, bail out */
/* Calculate the number of entries to dequeue in rx_q */
num = min(num_rq, num_fq);
num = min(num, (unsigned)MBUF_BURST_SZ);
/* Return if no entry in rx_q and no free entry in free_q */
if (num == 0)
return; return;
}
/* Calculate the number of entries to dequeue from rx_q */
num = min(num_fq, (unsigned)MBUF_BURST_SZ);
/* Burst dequeue from rx_q */ /* Burst dequeue from rx_q */
ret = kni_fifo_get(kni->rx_q, (void **)va, num); ret = kni_fifo_get(kni->rx_q, (void **)va, num);
if (ret == 0) if (ret == 0)
return; /* Failing should not happen */ return;
/* Transfer received packets to netif */ /* Transfer received packets to netif */
for (i = 0; i < num; i++) { for (i = 0; i < num; i++) {