d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dma/idxd: fix burst capacity calculation

Browse Source 
When the maximum burst size supported by HW is less than the available
ring space, incorrect capacity was returned when there was already some
jobs queued up for submission. This was because the capacity calculation
failed to subtract the number of already-enqueued jobs from the max
burst size. After subtraction is done, ensure that any negative values
(which should never occur if the user respects the reported limits), are
clamped to zero.

Fixes: 9459de4edc ("dma/idxd: add burst capacity")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
Tested-by: Jiayu Hu <jiayu.hu@intel.com>
This commit is contained in:
Bruce Richardson 2022-01-11 13:41:02 +00:00 committed by Thomas Monjalon
parent 62c21c38a2
commit a2b43447e9
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/dma/idxd/idxd_common.c
View File

@ -485,7 +485,9 @@ idxd_burst_capacity(const void *dev_private, uint16_t vchan __rte_unused)
write_idx += idxd->desc_ring_mask + 1;
used_space = write_idx - idxd->ids_returned;
return RTE_MIN((idxd->desc_ring_mask - used_space), idxd->max_batch_size);
const int ret = RTE_MIN((idxd->desc_ring_mask - used_space),
(idxd->max_batch_size - idxd->batch_size));
return ret < 0 ? 0 : (uint16_t)ret;
}
int