d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

timer: remove unnecessary list insertion

Browse Source 
When timer_set_running_state() fails in rte_timer_manage(),
the failed timer is put back on pending-list.
In this case, another core tries to reset or stop the timer.
It does not need to be on pending-list.

Fixes: a4b7a5a45cf5 ("timer: fix race condition")

Signed-off-by: Hiroyuki Mikita <h.mikita89@gmail.com>
Acked-by: Robert Sanford <rsanford@akamai.com>
This commit is contained in:
Hiroyuki Mikita 2016-07-18 02:35:50 +09:00 committed by Thomas Monjalon
parent d43baa8503
commit a829d41f9d
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/librte_timer/rte_timer.c
View File

@ -564,10 +564,9 @@ void rte_timer_manage(void)
pprev = &tim->sl_next[0]; pprev = &tim->sl_next[0];
} else { } else {
/* another core is trying to re-config this one, /* another core is trying to re-config this one,
* remove it from local expired list and put it * remove it from local expired list
* back on the priv_timer[] skip list */ */
*pprev = next_tim; *pprev = next_tim;
timer_add(tim, lcore_id, 1);
} }
} }