d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

raw/cnxk_gpio: fix resource leak

Browse Source 
All used resources need to be properly cleaned up in error path.

Fixes: 0e6557b448 ("raw/cnxk_gpio: add self test")
Coverity issue: 376504

Signed-off-by: Tomasz Duszynski <tduszynski@marvell.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
This commit is contained in:
Tomasz Duszynski 2022-02-22 09:28:16 +01:00 committed by Thomas Monjalon
parent 4476bfdd79
commit a8e1030905
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
drivers/raw/cnxk_gpio/cnxk_gpio.c
View File

@ -178,24 +178,30 @@ cnxk_gpio_parse_allowlist(struct cnxk_gpiochip *gpiochip)
static int
cnxk_gpio_read_attr(char *attr, char *val)
{
int ret, ret2;
FILE *fp;
int ret;
fp = fopen(attr, "r");
if (!fp)
return -errno;
ret = fscanf(fp, "%s", val);
if (ret < 0)
return -errno;
if (ret != 1)
return -EIO;
if (ret < 0) {
ret = -errno;
goto out;
}
if (ret != 1) {
ret = -EIO;
goto out;
}
ret = fclose(fp);
if (ret)
return -errno;
ret = 0;
out:
ret2 = fclose(fp);
if (!ret)
ret = ret2;
return 0;
return ret;
}
static int