d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/mlx5: remove unnecessary init in socket creation

Browse Source 
In the mlx5_pmd_socket_handle function it calls the recvmsg function
which returns the number of bytes read. The function assigns this return
value into a ret variable defined at the beginning of the function.
Similarly in the mlx5_pmd_socket_init function the it calls the socket
function which returns a file descriptor for the new socket. The
function also assigns this return value into a ret variable defined at
the beginning of the function.

In both functions they initialize the variable when defining it,
however, in both cases they do not use any ret variable before assigning
the return value from the function, so the initialization is
unnecessary.

Clean the aforementioned unnecessary initializations.

Fixes: e6cdc54cc0 ("net/mlx5: add socket server for external tools")
Cc: stable@dpdk.org

Signed-off-by: Michael Baum <michaelba@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
This commit is contained in:
Michael Baum 2020-05-27 08:37:54 +00:00 committed by Ferruh Yigit
parent ebed623f62
commit a943102fc6
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/net/mlx5/mlx5_socket.c
View File

@ -37,7 +37,7 @@ static void
mlx5_pmd_socket_handle(void *cb __rte_unused)
{
int conn_sock;
int ret = -1;
int ret;
struct cmsghdr *cmsg = NULL;
int data;
char buf[CMSG_SPACE(sizeof(int))] = { 0 };
@ -163,7 +163,7 @@ mlx5_pmd_socket_init(void)
struct sockaddr_un sun = {
.sun_family = AF_UNIX,
};
int ret = -1;
int ret;
int flags;
MLX5_ASSERT(rte_eal_process_type() == RTE_PROC_PRIMARY);