d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

examples/l3fwd-acl: check fseek return

Browse Source 
Add return value check and error handling for fseek call.

Coverity issue: 143435
Fixes: 361b2e9559 ("acl: new sample l3fwd-acl")

Signed-off-by: Kuba Kozak <kubax.kozak@intel.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Zhiyong Yang <zhiyong.yang@intel.com>
This commit is contained in:
Kuba Kozak 2017-10-03 13:48:02 +02:00 committed by Thomas Monjalon
parent 9b85b871cc
commit ab9cfe43c2
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
examples/l3fwd-acl/main.c
View File

@ -1026,6 +1026,7 @@ add_rules(const char *rule_path,
char buff[LINE_MAX]; char buff[LINE_MAX];
FILE *fh = fopen(rule_path, "rb"); FILE *fh = fopen(rule_path, "rb");
unsigned int i = 0; unsigned int i = 0;
int val;
if (fh == NULL) if (fh == NULL)
rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__, rte_exit(EXIT_FAILURE, "%s: Open %s failed\n", __func__,
@ -1042,7 +1043,11 @@ add_rules(const char *rule_path,
rte_exit(EXIT_FAILURE, "Not find any route entries in %s!\n", rte_exit(EXIT_FAILURE, "Not find any route entries in %s!\n",
rule_path); rule_path);
fseek(fh, 0, SEEK_SET); val = fseek(fh, 0, SEEK_SET);
if (val < 0) {
rte_exit(EXIT_FAILURE, "%s: File seek operation failed\n",
__func__);
}
acl_rules = calloc(acl_num, rule_size); acl_rules = calloc(acl_num, rule_size);