d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

compress/isal: fix use after free

Browse Source 
The release function was using qp->stream after already
releasing it and the null pointer checking was missing.

Also since rte_free(NULL) is a no-op, remove unnecessary
checks for NULL.

Coverity issure: 340860
Fixes: dc49e6aa4879 ("compress/isal: add ISA-L compression functionality")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Lee Daly <lee.daly@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
This commit is contained in:
Stephen Hemminger 2019-05-21 07:47:13 -07:00 committed by Akhil Goyal
parent e7d49fcdef
commit abdb798ae2
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
drivers/compress/isal/isal_compress_pmd_ops.c
View File

@ -171,18 +171,12 @@ isal_comp_pmd_qp_release(struct rte_compressdev *dev, uint16_t qp_id)
if (qp == NULL)
return -EINVAL;
if (qp->stream != NULL)
rte_free(qp->stream);
if (qp->stream->level_buf != NULL)
if (qp->stream)
rte_free(qp->stream->level_buf);
if (qp->state != NULL)
rte_free(qp->state);
if (qp->processed_pkts != NULL)
rte_ring_free(qp->processed_pkts);
rte_free(qp->state);
rte_ring_free(qp->processed_pkts);
rte_free(qp->stream);
rte_free(qp);
dev->data->queue_pairs[qp_id] = NULL;