d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

devtools: fix check of symbol added as stable API

Browse Source 
The incriminated commit broke the detection of new symbols skipping the
EXPERIMENTAL step before entering a stable ABI section.
sed won't return an error, check a null output instead.

Fixes: 3630757803ab ("devtools: accept experimental symbol promotion")
Cc: stable@dpdk.org

Signed-off-by: David Marchand <david.marchand@redhat.com>
This commit is contained in:
David Marchand 2019-05-03 16:34:20 +02:00 committed by Thomas Monjalon
parent d4ef40f3c6
commit af14b150df
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
devtools/check-symbol-change.sh
View File

@ -110,15 +110,24 @@ check_for_rule_violations()
# A symbol can not enter a non experimental
# section directly
if [ $? -ne 0 ] && [ "$secname" != 'EXPERIMENTAL' ]
if [ -z "$oldsecname" ]
then
echo -n "ERROR: symbol $symname "
echo -n "is added in the $secname "
echo -n "section, but is expected to "
echo -n "be added in the EXPERIMENTAL "
echo "section of the version map"
ret=1
continue
if [ "$secname" = 'EXPERIMENTAL' ]
then
echo -n "INFO: symbol $symname has "
echo -n "been added to the "
echo -n "EXPERIMENTAL section of the "
echo "version map"
continue
else
echo -n "ERROR: symbol $symname "
echo -n "is added in the $secname "
echo -n "section, but is expected to "
echo -n "be added in the EXPERIMENTAL "
echo "section of the version map"
ret=1
continue
fi
fi
# This symbol is moving inside a section, nothing to do