d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

dma/idxd: fix null dereference in PCI remove

Browse Source 
The 'info' struct was being declared as a NULL pointer. If a NULL
pointer is passed to 'rte_dma_info_get', EINVAL is returned and the
struct is not populated. This subsequently causes a segfault when
dereferencing 'info'.

This patch fixes the issue by simply declaring 'info' on the stack and
passing its address to 'rte_dma_info_get'.

Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
Cc: stable@dpdk.org

Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
This commit is contained in:
Kevin Laatz 2022-07-04 16:27:51 +01:00 committed by Thomas Monjalon
parent 1a57c8d553
commit b29427649b
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/dma/idxd/idxd_pci.c
View File

@ -380,10 +380,10 @@ idxd_dmadev_remove_pci(struct rte_pci_device *dev)
IDXD_PMD_INFO("Closing %s on NUMA node %d", name, dev->device.numa_node);
RTE_DMA_FOREACH_DEV(i) {
struct rte_dma_info *info = {0};
rte_dma_info_get(i, info);
if (strncmp(name, info->dev_name, strlen(name)) == 0)
idxd_dmadev_destroy(info->dev_name);
struct rte_dma_info info;
rte_dma_info_get(i, &info);
if (strncmp(name, info.dev_name, strlen(name)) == 0)
idxd_dmadev_destroy(info.dev_name);
}
return 0;