d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/ena/base: use optimized memcpy version also on Arm

Browse Source 
As the default behavior for arm64 is to alias rte_memcpy as memcpy, ENA
cannot redefine memcpy as rte_memcpy as it would cause nested
declaration.

To make it possible to use optimized memcpy in the ena_com layer on Arm,
the driver now redefines memcpy when it is beneficial:
  * For arm64 only when the flag RTE_ARCH_ARM64_MEMCPY was defined
  * For arm only when the flag RTE_ARCH_ARM_NEON_MEMCPY was defined

Signed-off-by: Michal Krawczyk <mk@semihalf.com>
Reviewed-by: Dawid Gorecki <dgr@semihalf.com>
Reviewed-by: Shai Brandes <shaibran@amazon.com>
This commit is contained in:
Michal Krawczyk 2022-02-23 13:19:32 +01:00 committed by Ferruh Yigit
parent 67216c31e4
commit b2c1fe38ad
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
doc/guides/rel_notes/release_22_03.rst
View File

@ -111,6 +111,7 @@ New Features
* Added new checksum related xstats: ``l3_csum_bad``, ``l4_csum_bad`` and
``l4_csum_good``.
* Added support for the link status configuration.
* Added optimized memcpy support for the ARM platforms.
* **Updated Cisco enic driver.**

7
drivers/net/ena/base/ena_plat_dpdk.h
View File

@ -66,8 +66,11 @@ typedef uint64_t dma_addr_t;
#define ENA_UDELAY(x) rte_delay_us_block(x)
#define ENA_TOUCH(x) ((void)(x))
/* Avoid nested declaration on arm64, as it may define rte_memcpy as memcpy. */
#if defined(RTE_ARCH_X86)
/* Redefine memcpy with caution: rte_memcpy can be simply aliased to memcpy, so
* make the redefinition only if it's safe (and beneficial) to do so.
*/
#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64_MEMCPY) || \
defined(RTE_ARCH_ARM_NEON_MEMCPY)
#undef memcpy
#define memcpy rte_memcpy
#endif