d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

devargs: parse global device syntax

Browse Source 
When parsing a devargs, try to parse using the global device syntax
first. Fallback on legacy syntax on error.

Example of new global device syntax:
 -a bus=pci,addr=82:00.0/class=eth/driver=mlx5,dv_flow_en=1

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Reviewed-by: Gaetan Rivet <grive@u256.net>
This commit is contained in:
Xueming Li 2021-04-13 03:14:12 +00:00 committed by Thomas Monjalon
parent d2a66ad794
commit b344eb5d94
3 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
doc/guides/rel_notes/release_21_11.rst
View File

@ -55,6 +55,13 @@ New Features
Also, make sure to start the actual text at the margin. Also, make sure to start the actual text at the margin.
======================================================= =======================================================
* **Enabled new devargs parser.**
* Enabled devargs syntax
``bus=X,paramX=x/class=Y,paramY=y/driver=Z,paramZ=z``
* Added bus-level parsing of the devargs syntax.
* Kept compatibility with the legacy syntax as parsing fallback.
Removed Items Removed Items
------------- -------------

10
lib/eal/common/eal_common_devargs.c
View File

@ -125,7 +125,6 @@ rte_devargs_layers_parse(struct rte_devargs *devargs,
layers[i].str = s; layers[i].str = s;
layers[i].kvlist = rte_kvargs_parse_delim(s, NULL, "/"); layers[i].kvlist = rte_kvargs_parse_delim(s, NULL, "/");
if (layers[i].kvlist == NULL) { if (layers[i].kvlist == NULL) {
RTE_LOG(ERR, EAL, "Could not parse %s\n", s);
ret = -EINVAL; ret = -EINVAL;
goto get_out; goto get_out;
} }
@ -224,6 +223,15 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)
if (da == NULL) if (da == NULL)
return -EINVAL; return -EINVAL;
/* First parse according global device syntax. */
if (rte_devargs_layers_parse(da, dev) == 0) {
if (da->bus != NULL || da->cls != NULL)
return 0;
rte_devargs_reset(da);
}
/* Otherwise fallback to legacy syntax: */
/* Retrieve eventual bus info */ /* Retrieve eventual bus info */
do { do {
devname = dev; devname = dev;

1
lib/ethdev/rte_ethdev.c
View File

@ -214,7 +214,6 @@ rte_eth_iterator_init(struct rte_dev_iterator *iter, const char *devargs_str)
* - 0000:08:00.0,representor=[1-3] * - 0000:08:00.0,representor=[1-3]
* - pci:0000:06:00.0,representor=[0,5] * - pci:0000:06:00.0,representor=[0,5]
* - class=eth,mac=00:11:22:33:44:55 * - class=eth,mac=00:11:22:33:44:55
* A new syntax is in development (not yet supported):
* - bus=X,paramX=x/class=Y,paramY=y/driver=Z,paramZ=z * - bus=X,paramX=x/class=Y,paramY=y/driver=Z,paramZ=z
*/ */