d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ipsec: fix use of uninitialized variable

Browse Source 
Defects reported by coverity scan
uninit_use_in_call: Using uninitialized element of array clen when
calling cpu_crypto_bulk.

Coverity issue: 354233, 354234
Fixes: 957394f72658 ("ipsec: support CPU crypto mode")

Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
This commit is contained in:
Konstantin Ananyev 2020-02-19 00:23:02 +00:00 committed by Akhil Goyal
parent e162f1a751
commit b38aaf1733
3 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/librte_ipsec/esp_inb.c
View File

@ -737,7 +737,9 @@ cpu_inb_pkt_prepare(const struct rte_ipsec_session *ss,
move_bad_mbufs(mb, dr, num, num - k);
/* convert mbufs to iovecs and do actual crypto/auth processing */
cpu_crypto_bulk(ss, sa->cofs, mb, iv, aad, dgst, l4ofs, clen, k);
if (k != 0)
cpu_crypto_bulk(ss, sa->cofs, mb, iv, aad, dgst,
l4ofs, clen, k);
return k;
}

4
lib/librte_ipsec/esp_outb.c
View File

@ -502,7 +502,9 @@ cpu_outb_pkt_prepare(const struct rte_ipsec_session *ss,
move_bad_mbufs(mb, dr, n, n - k);
/* convert mbufs to iovecs and do actual crypto/auth processing */
cpu_crypto_bulk(ss, sa->cofs, mb, iv, aad, dgst, l4ofs, clen, k);
if (k != 0)
cpu_crypto_bulk(ss, sa->cofs, mb, iv, aad, dgst,
l4ofs, clen, k);
return k;
}

3
lib/librte_ipsec/misc.h
View File

@ -106,7 +106,8 @@ mbuf_cut_seg_ofs(struct rte_mbuf *mb, struct rte_mbuf *ms, uint32_t ofs,
}
/*
* process packets using sync crypto engine
* process packets using sync crypto engine.
* expects *num* to be greater than zero.
*/
static inline void
cpu_crypto_bulk(const struct rte_ipsec_session *ss,