d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

service: introduce per-lcore cycles counter

Browse Source 
Introduce a per-lcore counter for the total time spent on processing
services on that core.

This counter is useful when measuring individual lcore load.

Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
This commit is contained in:
Mattias Rönnblom 2022-10-05 11:16:11 +02:00 committed by David Marchand
parent eb111cbdc2
commit b54ade8f24
3 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/test/test_service_cores.c
View File

@ -403,7 +403,7 @@ service_lcore_attr_get(void)
"lcore_attr_get() failed to get loops "
"(expected > zero)");
lcore_attr_id++; // invalid lcore attr id
lcore_attr_id = 42; /* invalid lcore attr id */
TEST_ASSERT_EQUAL(-EINVAL, rte_service_lcore_attr_get(slcore_id,
lcore_attr_id, &lcore_attr_value),
"Invalid lcore attr didn't return -EINVAL");

15
lib/eal/common/rte_service.c
View File

@ -66,6 +66,7 @@ struct core_state {
uint8_t is_service_core; /* set if core is currently a service core */
uint8_t service_active_on_lcore[RTE_SERVICE_NUM_MAX];
uint64_t loops;
uint64_t cycles;
struct service_stats service_stats[RTE_SERVICE_NUM_MAX];
} __rte_cache_aligned;
@ -376,6 +377,9 @@ service_runner_do_callback(struct rte_service_spec_impl *s,
* is needed, and not the more expensive atomic
* add.
*/
__atomic_store_n(&cs->cycles, cs->cycles + cycles,
__ATOMIC_RELAXED);
struct service_stats *service_stats =
&cs->service_stats[service_idx];
@ -817,6 +821,14 @@ lcore_attr_get_loops(unsigned int lcore)
return __atomic_load_n(&cs->loops, __ATOMIC_RELAXED);
}
static uint64_t
lcore_attr_get_cycles(unsigned int lcore)
{
struct core_state *cs = &lcore_states[lcore];
return __atomic_load_n(&cs->cycles, __ATOMIC_RELAXED);
}
static uint64_t
lcore_attr_get_service_calls(uint32_t service_id, unsigned int lcore)
{
@ -902,6 +914,9 @@ rte_service_lcore_attr_get(uint32_t lcore, uint32_t attr_id,
case RTE_SERVICE_LCORE_ATTR_LOOPS:
*attr_value = lcore_attr_get_loops(lcore);
return 0;
case RTE_SERVICE_LCORE_ATTR_CYCLES:
*attr_value = lcore_attr_get_cycles(lcore);
return 0;
default:
return -EINVAL;
}

6
lib/eal/include/rte_service.h
View File

@ -407,6 +407,12 @@ int32_t rte_service_attr_reset_all(uint32_t id);
*/
#define RTE_SERVICE_LCORE_ATTR_LOOPS 0
/**
* Returns the total number of cycles that the lcore has spent on
* running services.
*/
#define RTE_SERVICE_LCORE_ATTR_CYCLES 1
/**
* Get an attribute from a service core.
*