d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/kni: warn on stop failure

Browse Source 
Return value of function 'eth_kni_dev_stop' passed to 'ret' is
rewritten later, and this is unreasonable.

This patch fixes it.

Fixes: 62024eb82756 ("ethdev: change stop operation callback to return int")
Cc: stable@dpdk.org

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
This commit is contained in:
Min Hu (Connor) 2021-04-27 10:08:45 +08:00 committed by Ferruh Yigit
parent 8f3ca7f9a8
commit b752fb4d62
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/net/kni/rte_eth_kni.c
View File

@ -211,6 +211,9 @@ eth_kni_close(struct rte_eth_dev *eth_dev)
return 0;
ret = eth_kni_dev_stop(eth_dev);
if (ret)
PMD_LOG(WARNING, "Not able to stop kni for %s",
eth_dev->data->name);
/* mac_addrs must not be freed alone because part of dev_private */
eth_dev->data->mac_addrs = NULL;