d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/virtio-user: fix devargs parsing

Browse Source 
strtoull returns 0 if it fails to parse input string. It's ignored
in get_integer_arg.

This patch handles error cases for strtoull function.

Fixes: ce2eabdd43 ("net/virtio-user: add virtual device")
Cc: stable@dpdk.org

Signed-off-by: Ivan Dyukov <i.dyukov@samsung.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
This commit is contained in:
Ivan Dyukov 2020-03-30 10:58:00 +03:00 committed by Ferruh Yigit
parent 49119e3855
commit bc5b6c11bd
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
drivers/net/virtio/virtio_user_ethdev.c
View File

@ -477,12 +477,17 @@ static int
get_integer_arg(const char *key __rte_unused,
const char *value, void *extra_args)
{
uint64_t integer = 0;
if (!value || !extra_args)
return -EINVAL;
*(uint64_t *)extra_args = strtoull(value, NULL, 0);
return 0;
errno = 0;
integer = strtoull(value, NULL, 0);
/* extra_args keeps default value, it should be replaced
* only in case of successful parsing of the 'value' arg
*/
if (errno == 0)
*(uint64_t *)extra_args = integer;
return -errno;
}
static struct rte_eth_dev *