d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

telemetry: fix error checking for strchr function

Browse Source 
The strchr function return was not being checked which could lead to
NULL deferencing later in the function.

Coverity issue: 358438, 358445
Fixes: b80fe1805eee ("telemetry: introduce backward compatibility")

Signed-off-by: Ciara Power <ciara.power@intel.com>
Acked-by: Kevin Laatz <kevin.laatz@intel.com>
This commit is contained in:
Ciara Power 2020-05-12 16:28:59 +01:00 committed by Thomas Monjalon
parent febbebf7f2
commit bd3c89cb1a
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/librte_telemetry/telemetry_legacy.c
View File

@ -82,8 +82,16 @@ register_client(const char *cmd __rte_unused, const char *params,
int fd; int fd;
struct sockaddr_un addrs; struct sockaddr_un addrs;
if (!strchr(params, ':')) {
fprintf(stderr, "Invalid data\n");
return -1;
}
strlcpy(data, strchr(params, ':'), sizeof(data)); strlcpy(data, strchr(params, ':'), sizeof(data));
memcpy(data, &data[strlen(":\"")], strlen(data)); memcpy(data, &data[strlen(":\"")], strlen(data));
if (!strchr(data, '\"')) {
fprintf(stderr, "Invalid client data\n");
return -1;
}
*strchr(data, '\"') = 0; *strchr(data, '\"') = 0;
fd = socket(AF_UNIX, SOCK_SEQPACKET, 0); fd = socket(AF_UNIX, SOCK_SEQPACKET, 0);
@ -178,6 +186,8 @@ parse_client_request(char *buffer, int buf_len, int s)
if (!strchr(data_ptr, '{')) if (!strchr(data_ptr, '{'))
data_sep = data_ptr[strlen(callbacks[i].data)]; data_sep = data_ptr[strlen(callbacks[i].data)];
else { else {
if (!strchr(data_ptr, '}'))
return -EINVAL;
char *data_end = strchr(data_ptr, '}'); char *data_end = strchr(data_ptr, '}');
data = data_ptr + strlen(DATA_REQ_LABEL); data = data_ptr + strlen(DATA_REQ_LABEL);
data_sep = data_end[1]; data_sep = data_end[1];