d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

raw/ifpga/base: check file length

Browse Source 
In fpga_update_flash(), "smgr->rsu_length" is passed to a
parameter that cannot be negative. So return value of
function "lseek" should be checked before being assigned
to "smgr->rsu_length".

Coverity issue: 367481
Fixes: a05bd1b40b ("raw/ifpga: add FPGA RSU APIs")

Signed-off-by: Wei Huang <wei.huang@intel.com>
Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
Acked-by: Rosen Xu <rosen.xu@intel.com>
This commit is contained in:
Wei Huang 2021-03-17 04:21:35 -04:00 committed by Qi Zhang
parent 226ecdea99
commit bf95921a01
1 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
drivers/raw/ifpga/base/ifpga_fme_rsu.c
View File

@ -275,6 +275,7 @@ int fpga_update_flash(struct ifpga_fme_hw *fme, const char *image,
struct ifpga_sec_mgr *smgr = NULL; struct ifpga_sec_mgr *smgr = NULL;
uint32_t rsu_stat = 0; uint32_t rsu_stat = 0;
int fd = -1; int fd = -1;
off_t len = 0;
struct sigaction old_sigint_action; struct sigaction old_sigint_action;
struct sigaction sa; struct sigaction sa;
time_t start; time_t start;
@ -318,9 +319,21 @@ int fpga_update_flash(struct ifpga_fme_hw *fme, const char *image,
image, strerror(errno)); image, strerror(errno));
return -EIO; return -EIO;
} }
smgr->rsu_length = lseek(fd, 0, SEEK_END); len = lseek(fd, 0, SEEK_END);
close(fd); close(fd);
if (len < 0) {
dev_err(smgr,
"Failed to get file length of \'%s\' [e:%s]\n",
image, strerror(errno));
return -EIO;
}
if (len == 0) {
dev_err(smgr, "Length of file \'%s\' is invalid\n", image);
return -EINVAL;
}
smgr->rsu_length = len;
if (smgr->max10_dev->staging_area_size < smgr->rsu_length) { if (smgr->max10_dev->staging_area_size < smgr->rsu_length) {
dev_err(dev, "Size of staging area is small than image length " dev_err(dev, "Size of staging area is small than image length "
"[%u<%u]\n", smgr->max10_dev->staging_area_size, "[%u<%u]\n", smgr->max10_dev->staging_area_size,