d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

net/hns3: delete unused markup

Browse Source 
The '__rte_unused' tag in the input parameter  of 'hns3_mac_stats_reset'
is redundant. This patch remove this tag. In addition, this function is
aimed to clear MAC statics. So using 'struct hns3_hw' as input parameter
is better than 'struct rte_eth_dev', and it also facilitates the call of
this function.

Fixes: 8839c5e202 ("net/hns3: support device stats")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
This commit is contained in:
Huisong Li 2022-09-05 16:59:37 +08:00 committed by Andrew Rybchenko
parent a8f1f7cf1b
commit c05a540902
1 changed files with 5 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
drivers/net/hns3/hns3_stats.c
View File

@ -406,15 +406,6 @@ hns3_query_mac_stats_reg_num(struct hns3_hw *hw)
return 0;
}
static int
hns3_query_update_mac_stats(struct rte_eth_dev *dev)
{
struct hns3_adapter *hns = dev->data->dev_private;
struct hns3_hw *hw = &hns->hw;
return hns3_update_mac_stats(hw);
}
static int
hns3_update_port_rpu_drop_stats(struct hns3_hw *hw)
{
@ -763,14 +754,13 @@ hns3_stats_reset(struct rte_eth_dev *eth_dev)
}
static int
hns3_mac_stats_reset(__rte_unused struct rte_eth_dev *dev)
hns3_mac_stats_reset(struct hns3_hw *hw)
{
struct hns3_adapter *hns = dev->data->dev_private;
struct hns3_hw *hw = &hns->hw;
struct hns3_mac_stats *mac_stats = &hw->mac_stats;
int ret;
ret = hns3_query_update_mac_stats(dev);
/* Clear hardware MAC statistics by reading it. */
ret = hns3_update_mac_stats(hw);
if (ret) {
hns3_err(hw, "Clear Mac stats fail : %d", ret);
return ret;
@ -1063,8 +1053,7 @@ hns3_dev_xstats_get(struct rte_eth_dev *dev, struct rte_eth_xstat *xstats,
hns3_tqp_basic_stats_get(dev, xstats, &count);
if (!hns->is_vf) {
/* Update Mac stats */
ret = hns3_query_update_mac_stats(dev);
ret = hns3_update_mac_stats(hw);
if (ret < 0) {
hns3_err(hw, "Update Mac stats fail : %d", ret);
rte_spinlock_unlock(&hw->stats_lock);
@ -1482,8 +1471,7 @@ hns3_dev_xstats_reset(struct rte_eth_dev *dev)
if (hns->is_vf)
goto out;
/* HW registers are cleared on read */
ret = hns3_mac_stats_reset(dev);
ret = hns3_mac_stats_reset(hw);
out:
rte_spinlock_unlock(&hw->stats_lock);