d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

bus: remove useless plug parameter

Browse Source 
The prior scan should link the relevant rte_devargs to the newly
allocated rte_device. As such, it is useless to pass device arguments to
the plug callback. Those arguments are available within the devargs
field of the rte_device structure.

Fixes: 7c8810f43f6e ("bus: introduce device plug/unplug")
Fixes: 00e62aae69c0 ("bus/pci: implement plug/unplug operations")
Fixes: a3ee360f4440 ("eal: add hotplug add/remove device")

Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>
This commit is contained in:
Gaetan Rivet 2017-07-15 19:56:42 +02:00 committed by Thomas Monjalon
parent cbc30ea872
commit c0e2821041
4 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/librte_eal/common/eal_common_dev.c
View File

@ -187,7 +187,7 @@ int rte_eal_hotplug_add(const char *busname, const char *devname,
goto err_devarg;
}
ret = bus->plug(dev, devargs);
ret = bus->plug(dev);
if (ret) {
RTE_LOG(ERR, EAL, "Driver cannot attach the device (%s)\n",
dev->name);

2
lib/librte_eal/common/eal_common_pci.c
View File

@ -541,7 +541,7 @@ pci_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
}
static int
pci_plug(struct rte_device *dev, const char *devargs __rte_unused)
pci_plug(struct rte_device *dev)
{
return pci_probe_all_drivers(RTE_DEV_TO_PCI(dev));
}

2
lib/librte_eal/common/eal_common_vdev.c
View File

@ -319,7 +319,7 @@ vdev_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
}
static int
vdev_plug(struct rte_device *dev, const char *args __rte_unused)
vdev_plug(struct rte_device *dev)
{
return vdev_probe_all_drivers(RTE_DEV_TO_VDEV(dev));
}

6
lib/librte_eal/common/include/rte_bus.h
View File

@ -113,15 +113,11 @@ typedef struct rte_device *
* @param dev
* Device pointer that was returned by a previous call to find_device.
*
* @param devargs
* Device declaration.
*
* @return
* 0 on success.
* !0 on error.
*/
typedef int (*rte_bus_plug_t)(struct rte_device *dev,
const char *devargs);
typedef int (*rte_bus_plug_t)(struct rte_device *dev);
/**
* Implementation specific remove function which is responsible for unlinking