d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

log: catch invalid level option number

Browse Source 
The parsing check for invalid log level was not trying to catch
irrelevant numeric values.
A log level 0 becomes a failure in parsing so it can be caught early.
A log level higher than the max (8) is accepted with a warning message.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Reviewed-by: David Marchand <david.marchand@redhat.com>
This commit is contained in:
Thomas Monjalon 2021-04-08 18:47:12 +02:00 committed by David Marchand
parent 806d888a80
commit c2bd208a90
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/librte_eal/common/eal_common_options.c
View File

@ -1289,10 +1289,15 @@ eal_parse_log_level(const char *arg)
}
priority = eal_parse_log_priority(level);
if (priority < 0) {
fprintf(stderr, "invalid log priority: %s\n", level);
if (priority <= 0) {
fprintf(stderr, "Invalid log level: %s\n", level);
goto fail;
}
if (priority > (int)RTE_LOG_MAX) {
fprintf(stderr, "Log level %d higher than maximum (%d)\n",
priority, RTE_LOG_MAX);
priority = RTE_LOG_MAX;
}
if (regex) {
if (rte_log_set_level_regexp(regex, priority) < 0) {