d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

bus/pci: fix TOCTOU for sysfs access

Browse Source 
Using access followed by open causes a static analysis warning
about Time of check versus Time of use. Also, access() and
open() have different UID permission checks.

This is not a serious problem; but easy to fix by using errno instead.

Coverity issue: 300870
Fixes: 4a928ef9f6 ("bus/pci: enable write combining during mapping")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: David Marchand <david.marchand@redhat.com>
This commit is contained in:
Stephen Hemminger 2019-04-02 11:51:05 -07:00 committed by Thomas Monjalon
parent 07517400c4
commit c530aa78e3
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
drivers/bus/pci/linux/pci_uio.c
View File

@ -315,12 +315,11 @@ pci_uio_map_resource_by_index(struct rte_pci_device *dev, int res_idx,
loc->domain, loc->bus, loc->devid,
loc->function, res_idx);
if (access(devname, R_OK|W_OK) != -1) {
fd = open(devname, O_RDWR);
if (fd < 0)
RTE_LOG(INFO, EAL, "%s cannot be mapped. "
"Fall-back to non prefetchable mode.\n",
devname);
fd = open(devname, O_RDWR);
if (fd < 0 && errno != ENOENT) {
RTE_LOG(INFO, EAL, "%s cannot be mapped. "
"Fall-back to non prefetchable mode.\n",
devname);
}
}