d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/eventdev: fix SMP barrier in performance test

Browse Source 
This patch fixes RTE SMP barrier bugs for the perf test of eventdev.

For the "perf_process_last_stage" function, wmb after storing
processed_pkts should be moved before it. This is because the worker
lcore should ensure it has really finished data processing, e.g. event
stored into buffers, before the shared variables "w->processed_pkts"are
stored.

For the "perf_process_last_stage_latency", on the one hand, the wmb
should be moved before storing into "w->processed_pkts". The reason is
the same as above. But on the other hand, for "w->latency", wmb is
unnecessary due to data dependency.

Fixes: 2369f73329 ("app/testeventdev: add perf queue worker functions")
Cc: stable@dpdk.org

Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
This commit is contained in:
Feifei Wang 2021-01-14 15:08:26 +08:00 committed by Jerin Jacob
parent f3527e0b97
commit c7c033d173
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
app/test-eventdev/test_perf_common.h
View File

@ -97,8 +97,13 @@ perf_process_last_stage(struct rte_mempool *const pool,
void *bufs[], int const buf_sz, uint8_t count) void *bufs[], int const buf_sz, uint8_t count)
{ {
bufs[count++] = ev->event_ptr; bufs[count++] = ev->event_ptr;
w->processed_pkts++;
/* wmb here ensures event_prt is stored before
* updating the number of processed packets
* for worker lcores
*/
rte_smp_wmb(); rte_smp_wmb();
w->processed_pkts++;
if (unlikely(count == buf_sz)) { if (unlikely(count == buf_sz)) {
count = 0; count = 0;
@ -116,6 +121,12 @@ perf_process_last_stage_latency(struct rte_mempool *const pool,
struct perf_elt *const m = ev->event_ptr; struct perf_elt *const m = ev->event_ptr;
bufs[count++] = ev->event_ptr; bufs[count++] = ev->event_ptr;
/* wmb here ensures event_prt is stored before
* updating the number of processed packets
* for worker lcores
*/
rte_smp_wmb();
w->processed_pkts++; w->processed_pkts++;
if (unlikely(count == buf_sz)) { if (unlikely(count == buf_sz)) {
@ -127,7 +138,6 @@ perf_process_last_stage_latency(struct rte_mempool *const pool,
} }
w->latency += latency; w->latency += latency;
rte_smp_wmb();
return count; return count;
} }