d/numam-dpdk
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

app/testpmd: add port check before manual detach

Browse Source 
User may try to run "port detach <port_id>"
for an already detached device.
It has been decided to protect from such usage in testpmd,
so a check was added to detach_port_device() in DPDK 19.11.
This check might be removed to allow hotplug path detaching
the device of a closed port.
Whatever will be decided in future, this check is also added
before the call to detach_port_device().

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
This commit is contained in:
Thomas Monjalon 2020-02-13 15:50:23 +01:00 committed by Ferruh Yigit
parent 4f37df14c4
commit c8743d5f15
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
app/test-pmd/cmdline.c
View File

@ -1497,10 +1497,12 @@ static void cmd_operate_detach_port_parsed(void *parsed_result,
{
struct cmd_operate_detach_port_result *res = parsed_result;
if (!strcmp(res->keyword, "detach"))
if (!strcmp(res->keyword, "detach")) {
RTE_ETH_VALID_PORTID_OR_RET(res->port_id);
detach_port_device(res->port_id);
else
} else {
printf("Unknown parameter\n");
}
}
cmdline_parse_token_string_t cmd_operate_detach_port_port =